tiny-agent: switch to autotools build#2
Open
vishnu-santhosh wants to merge 1 commit into
Open
Conversation
The Yocto recipe in meta-tiny-agent inherits the `autotools` class,
which expects a standard `./configure && make && make install
DESTDIR=...` flow. The hand-rolled Makefile supported none of what
the recipe needs:
- No `--host=` cross-compilation (Yocto builds on x86_64 host for
arm/x86_64 target via sysroot + cross-toolchain)
- No `DESTDIR` honored by install (breaks Yocto's `do_install`)
- No `--prefix`/`--sysconfdir` for FHS-correct file placement
- No `PKG_CHECK_MODULES` for sysroot-aware libcurl/jansson
detection (needed in Phase 2)
- No `make distcheck` to catch any of the above pre-package
Re-implementing all of that manually would mean rewriting half of
automake and getting it wrong. autoconf+automake is what Yocto
expects, so we use it.
configure.ac currently checks only for pty.h and forkpty() in
libutil; libcurl, jansson, and systemd detection are deferred to
the PRs that add code depending on them. Same source, same binary,
same behavior - only the build system changes.
Build: ./autogen.sh && ./configure && make
Verify: make distcheck (passes clean)
Clean: git clean -fdX (removes all gitignored autotools artifacts)
Binary moves from build/pty_test to src/pty_test.
vishnu-santhosh
force-pushed
the
feat/autotools
branch
from
ec56817 to
42487c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Yocto recipe in meta-tiny-agent inherits the
autotoolsclass, which expects a standard./configure && make && make install DESTDIR=...flow. The hand-rolled Makefile supported none of what the recipe needs:--host=cross-compilation (Yocto builds on x86_64 host for arm/x86_64 target via sysroot + cross-toolchain)DESTDIRhonored by install (breaks Yocto'sdo_install)--prefix/--sysconfdirfor FHS-correct file placementPKG_CHECK_MODULESfor sysroot-aware libcurl/jansson detection (needed in Phase 2)make distcheckto catch any of the above pre-packageRe-implementing all of that manually would mean rewriting half of automake and getting it wrong. autoconf+automake is what Yocto expects, so we use it.
configure.ac currently checks only for pty.h and forkpty() in libutil; libcurl, jansson, and systemd detection are deferred to the PRs that add code depending on them. Same source, same binary, same behavior - only the build system changes.
Build: ./autogen.sh && ./configure && make
Verify: make distcheck (passes clean)
Clean: git clean -fdX (removes all gitignored autotools artifacts)
Binary moves from build/pty_test to src/pty_test.